Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-7.0] use group secret for GetGroupSnapshotStatus #1057

Closed
wants to merge 1 commit into from
Closed

[release-7.0] use group secret for GetGroupSnapshotStatus #1057

wants to merge 1 commit into from

Conversation

Madhu-1
Copy link
Contributor

@Madhu-1 Madhu-1 commented Apr 4, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

GetGroupSnapshotStatus is a group operation on a specific group with an ID, we can use the group specific secret instead of List specific secret.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit b2447a0)

backport of #1051
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Cherry-pick from PR [#1051](https://github.com/kubernetes-csi/external-snapshotter/pull/1051)  Use Group secret for the GetGroupSnapshotStatus RPC call

@Madhu-1
use group secret for GetGroupSnapshotStatus
24f3bb6 
GetGroupSnapshotStatus is a group operation on
a specific group with an ID, we can use the
group specific secret instead of List specific
secret.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit b2447a0)
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Madhu-1
Once this PR has been reviewed and has the lgtm label, please assign jingxu97 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @Madhu-1. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2024
@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Apr 4, 2024

/assign @xing-yang

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2024
@xing-yang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2024
@Madhu-1
Copy link
Contributor Author

Madhu-1 commented May 15, 2024

@xing-yang is this good to get merged?

@xing-yang
Copy link
Collaborator

@xing-yang is this good to get merged?

@Madhu-1 We are going to cut a new release soon. I wonder if we still need to patch this in 7.0 branch.

@Madhu-1 Madhu-1 closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauriciopoppe mauriciopoppe Awaiting requested review from mauriciopoppe

@yuxiangqian yuxiangqian Awaiting requested review from yuxiangqian

Assignees

@xing-yang xing-yang

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Madhu-1 @k8s-ci-robot @xing-yang